Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

platform: document default installation files #188

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Conversation

rubensfig
Copy link
Contributor

@rubensfig rubensfig commented Jun 7, 2024

Document bisdn/meta-bisdn-linux/pull/203 functionality to provide default installation of l2 functionality.

Addresses bisdn/bisdn-linux#101.

@rubensfig rubensfig requested a review from KanjiMonster June 7, 2024 10:12
@rubensfig rubensfig requested a review from ideaship June 14, 2024 08:09
@rubensfig rubensfig requested a review from ideaship June 18, 2024 09:11
Copy link
Contributor

@KanjiMonster KanjiMonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would make more sense to put this into https://github.com/bisdn/bisdn.github.io/blob/main/getting_started/install_bisdn_linux.md instead of a separate page, since you might want to know about this before doing an installation.

@ideaship ideaship added documentation Improvements or additions to documentation next Documentation for changes not yet in a release labels Jun 18, 2024
@rubensfig rubensfig requested a review from KanjiMonster June 19, 2024 09:08
Copy link
Contributor Author

@rubensfig rubensfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed all comments

@rubensfig rubensfig requested a review from KanjiMonster July 4, 2024 08:32
Document bisdn/meta-bisdn-linux/pull/203 functionality to provide default
installation of l2 functionality.

Signed-off-by: Rubens Figueiredo <[email protected]>
Co-authored-by: ideaship <[email protected]>
Co-authored-by: Jonas Gorski <[email protected]>
@rubensfig rubensfig requested a review from KanjiMonster July 9, 2024 09:11
Copy link
Contributor

@KanjiMonster KanjiMonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KanjiMonster KanjiMonster merged commit 6082731 into main Jul 18, 2024
1 check passed
@KanjiMonster KanjiMonster deleted the l2_default_files branch July 18, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation next Documentation for changes not yet in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants